Review tempo charms for listing

charmhub requests review requests
1

The Tempo K8s charms together form a scaleable Tempo deployment. As these charms are maintained as a monorepo, I’ve opted for creating one review request for both charms. The assumption is that this will lead to a better review that is easier to overview both for the reviewer and us as the individual charms are never meant to be deployed in isolation.

Charms

tempo-worker-k8s

The worker is running the actual Tempo workload, allowing users to assign it a role and make it part of their scaled-out deployment.

tempo-coordinator-k8s

The coordinator is running an nginx reverse proxy, and is responsible for generating the configuration used by the workers based on configured roles.

Review PR

Metadata Links

CI Links

Documentation Links

Coordinator

Publisher: Simon Aronsson simon.aronsson@canonical.com, Canonical Observability Team

Review comments are to be directed to the tracing and profiling team, meaning @ppasotti, @mmkay, and @michaeldmitry.

2

@dimaqq is going to handle this one (two), thanks!

1 Like
3

@0x12b would these be more accurate charmhub links?

4

I’ve left one batch of review comments on the PR.

5

A summary of the GitHub comments, focusing on blocker level items:

  • some dependency automation, at last for security (renovate or dependabot or whatever)
  • icons (yes it’s tiny, but please)
  • tutorial (probably a matter of updating one link)

The rest are more informational, though I do hope that those items are considered.

Thank you!

6

icon and readme links are fixed (fix: review feedback: worker is missing an icon by PietroPasotti · Pull Request #151 · canonical/tempo-operators · GitHub)

re. the renovate thingy, we’re working on it

1 Like
7

renovate also merged

@dimaqq this closes all the blockers I think, we’ll make treasure of the other feedback and address it in our regular tech debt schedule

2 Likes
8

The PR fulfils the process criteria, approved!

P.S. I’ve left a few comments on smaller details in the PR.

2 Likes
9

Thanks @0x12b , @ppasotti , and @dimaqq !

@adityagoel28 this one is good for listing, thanks!

1 Like
10

Hi @tony-meyer , I have listed both the charms and they are visible.

Thanks!

2 Likes