I have finished the complete review process according to Charm maturity stage 1 and Reviewing charms.
A few minor details are missing, and here’s a summary:
- According to “Charm maturity stage 1”, there should be an icon. Currently, this charm is using the default Ubuntu icon, and I see some other charms use the same icon. So I guess this one is OK, but it’s a good time for you to change to a non-default icon if you wish.
- According to “Charm maturity stage 1”, the documentation should contain not only “how to use the charm”, but also “how to modify the charm” and “how to contribute to the development”. There is a similar requirement from “reviewing charms”, which says you should have “documentation for contributing”. I saw that there is already a
CONTRIBUTING.mdfile serving this purpose in the repository, but the link is not available on the Charmhub detail page. My suggestion is that maybe we can add this link to the Charmhub detail page. - According to “Charm maturity stage 1”, section “Community discussions”, A Discourse link or Mattermost channel must be available for discussion. Could you create a discourse post for this charm and add it to the Charmhub detail page/repository? If you have a Mattermost channel that’d be even better I think.
- According to “Reviewing charms”, installation test results, integration test results, etc. are required. In our call yesterday we walked through the installation process and verified the result. Maybe you can provide a short description of the result, like the commands we ran yesterday manually to deploy it to show the result in the original post or add some links to the CI result?
I have already reached out to the charm author @andrew-polukhin about these details. Since nothing major is missing and these probably can be fixed real soon, mean while, I will check what actions on our side are left to make it publicly searchable.