Hello, the powerstore-cinder charm allows cinder to manage volumes with a Dell PowerStore storage system as the backend. From configuration to operations, it enables the end user to automate the deployment and the usage of Cinder with Dell PowerStore.
We would like to have this charm visible and searchable from Charmhub.
I can’t find the charm on Charmhub. Based on the name in the metadata.yaml I’d expect it to be at Charmhub | Deploy Cinder Powerstore using Charmhub - The Open Operator Collection but that 404s. Have you managed to publish it at all? It definitely needs to have been published (at least to edge) before it can be publicly listed.
Checked
Review item
Objective
Review criteria
Intended functionality
The charm must work!
Charm does what it is meant to do. For charms that are easily used without specialised infrastructure, successfully completing the tutorial is sufficient. For more complex charms, the submitter should provide a (possibly prerecorded) demo.
A complete and consistent appearance of the charm is required for a quality impression of the charm collection.
The overall appearance looks good and the documentation looks reasonable.
✓
Release automation implementation
An implementation for automated releasing to charmhub.io improves the ability to provide updates covering vulnerabilities quickly.
Release automation for unstable channels to enable testing when new versions of the charm code or the workload become available.
Integration tests implemented
In particular for the review of charms, assuring a reasonable test suite is important to allow for automated releases in future. With this test, for every build, it is ensured that the integration with other charms is successful.
Integration tests verify that the charm can be deployed and ends up in a success state, and that the charm can be integrated with at least one example for each ‘provides’ and ‘requires’ specified (including optional, excluding tracing) ending up in a success state. The integration tests are currently passing.
✓
Coding conventions
The source code of the charm is accessible in the sense of approachability. Consistent source code style and formatting are also considered a sign of being committed to quality.
The implemented checks for coding conventions are reasonable and implemented in the regular CI/CD implementation.
✓
Documentation for contributing
The documentation for contributing to the charm should be separate from the documentation for developing or using the charm.
URL to this documentation is present and resolves with 2xx.
✓
Licensing statement
For the charm shared, OSS or not, the licensing terms of the charm are clarified (which also implies an identified authorship of the charm).
URL to the ruling licensing statement is present and resolves with 2xx.
✓
Metadata Links
A complete and consistent appearance of the charm is required.
charmcraft.yaml includes name, title, summary, and description fields that are not the default profile values, and a links field that contains documentation, issues, source, and contact fields, which resolve with 2xx.
@adityagoel28 are you able to help out with the store side of this? Can you see if the charm is registered to JP at least, or see why there was that permission error when trying to publish?
I can confirm that cinder-powerstore is registered to jproque15130.
@jproque15130 The permission error is most likely due to a restriction set on the channel in the token/secret. For CI, the minimal permissions should be something like:
package-manage-revisions - for uploading the revision
package-manage-releases - for releasing the revision
Additionally, you may choose to restrict the channels that the token/secret can release to with ie. --channel "mytrack/edge" --channel "mytrack/stable".
An example command to generate such a token might be:
(For what it’s worth, I’m meeting with a bunch of Canonical OpenStack people in person in a couple of weeks to try to get some general charming improvements going).
I’m good with this being listed now. We do want to tighten up the integration test story, but I think it’s better to have it as-is now, and then circle back to that in a few weeks once I’ve talked to the Canonical OpenStack people. I don’t think it should block public listing here.
The logo on each charm’s page (and in the search results) is actually the charm logo rather than the publisher logo. But if you wanted to have the same Dell logo for all of them I don’t see any reason why not.
You need to add an icon.svg file to each charm’s repository (and then publish again). The link has the size specifications and so on.
It will be found automatically if it’s at the top level (the same directory as charmcraft.yaml). You can put it elsewhere, but then need to add in to charmcraft.yaml instructions on where it should be sourced from.
.