Thanks for submitting the charm. I have a few issues that need to be addressed before I can approve this charm for listing.
- Links to at least the issue tracker are needed on Charmhub. Links can be specified in metadata.yaml.
- The maintainer is listed in metadata.yaml as
OpenStack Charmers <openstack-charmers@lists.ubuntu.com>. Is this correct? - The charm needs charmhub docs (Juju | How to add docs to your charm or charm bundle on Charmhub)
- I am unclear on the release process. There does not seem to be any automation in place to release to unstable channels. According to the approval criteria, the charm needs to be released to an unstable channel before stable.
- The charm does not clean up after itself. If the charm is removed, nothing happens. You need to implement the
removehook to uninstall the charm. - Test coverage is not good
- Integration tests are not run as part of CI/CD
Once you address these issues, let me know and I can take another pass at reviewing the charm.