Review httprequest-lego-provider for Listing

arturo-seijas · 5 December 2024 16:38

Metadata links

charmhub.io:

project repository:

CI Links

Code linting or-style checks:

canonical/httprequest-lego-provider/blob/main/.github/workflows/test.yaml

name: Tests

on:
  pull_request:

jobs:
  unit-tests:
    uses: canonical/operator-workflows/.github/workflows/test.yaml@main
    secrets: inherit
    with:
      self-hosted-runner: true
      self-hosted-runner-label: "edge"
  integration-tests:
    uses: canonical/operator-workflows/.github/workflows/integration_test.yaml@main
    secrets: inherit
    with:
      channel: 1.28-strict/stable
      juju-channel: 3.4/stable

Release automation:

github.com

canonical/httprequest-lego-provider/blob/main/.github/workflows/publish_charm.yaml

name: Publish to edge

on:
  push:
    branches:
      - main
      - track/*

jobs:
  publish-to-edge:
    uses: canonical/operator-workflows/.github/workflows/publish_charm.yaml@main
    secrets: inherit
    with:
      integration-test-workflow-file: test.yaml
      resource-mapping: '{"httprequest-lego-provider": "django-app-image"}'

Unit test implementation:

github.com

canonical/httprequest-lego-provider/blob/main/.github/workflows/test.yaml

name: Tests

on:
  pull_request:

jobs:
  unit-tests:
    uses: canonical/operator-workflows/.github/workflows/test.yaml@main
    secrets: inherit
    with:
      self-hosted-runner: true
      self-hosted-runner-label: "edge"
  integration-tests:
    uses: canonical/operator-workflows/.github/workflows/integration_test.yaml@main
    secrets: inherit
    with:
      channel: 1.28-strict/stable
      juju-channel: 3.4/stable

Unit test results:

Integration test implementation:

github.com

canonical/httprequest-lego-provider/blob/main/.github/workflows/test.yaml

name: Tests

on:
  pull_request:

jobs:
  unit-tests:
    uses: canonical/operator-workflows/.github/workflows/test.yaml@main
    secrets: inherit
    with:
      self-hosted-runner: true
      self-hosted-runner-label: "edge"
  integration-tests:
    uses: canonical/operator-workflows/.github/workflows/integration_test.yaml@main
    secrets: inherit
    with:
      channel: 1.28-strict/stable
      juju-channel: 3.4/stable

Integration test results: Charm review PR · canonical/httprequest-lego-provider@fb17fdc · GitHub

Documentation Links

Usage:

Contribution:

github.com

canonical/httprequest-lego-provider/blob/main/CONTRIBUTING.md

# Contributing

To make contributions to this charm, you'll need a working [development setup](https://juju.is/docs/sdk/dev-setup).

You can create an environment for development with `tox`:

```shell
tox devenv -e integration
source venv/bin/activate
```

## Testing

This project uses `tox` for managing test environments. There are some pre-configured environments
that can be used for linting and formatting code when you're preparing contributions to the charm:

```shell
tox run -e format        # update your code according to linting rules
tox run -e lint          # code style
tox run -e unit          # unit tests

This file has been truncated. show original

Licensing:

github.com

canonical/httprequest-lego-provider/blob/main/LICENSE


                                 Apache License
                           Version 2.0, January 2004
                        http://www.apache.org/licenses/

   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

   1. Definitions.

      "License" shall mean the terms and conditions for use, reproduction,
      and distribution as defined by Sections 1 through 9 of this document.

      "Licensor" shall mean the copyright owner or entity authorized by
      the copyright owner that is granting the License.

      "Legal Entity" shall mean the union of the acting entity and all
      other entities that control, are controlled by, or are under common
      control with that entity. For the purposes of this definition,
      "control" means (i) the power, direct or indirect, to cause the
      direction or management of such entity, whether by contract or

This file has been truncated. show original

Publisher:
Arturo Enrique Seijas Fernández arturo-seijas@canonical.com

tony-meyer · 5 December 2024 20:30

Thanks @arturo-seijas for the review request!

@dylanstathis can you please help with this review? You can go through and tick off the items on the checklist and post the result in this thread. This prior listing request could serve as an example of how to go about it. Please ping me or anyone from Charm-Tech for any questions.

dylanstathis · 21 February 2025 12:49

I have only one issue:

The only tests I can find are in the charm/tests directory and there is only “test_build_and_deploy” and “test_actions”. This is definitely not enough test coverage. If there are other tests somewhere else, please let me know, otherwise more tests need to be added.

Everything else looks fine to me so once the above is addressed, we can do the demo and get the charm approved.