Review httprequest-lego-provider for Listing

charmhub requests review requests
1

Metadata links

  • project repository:

CI Links

  • Code linting or-style checks:
  • Release automation:
  • Unit test implementation:
  • Unit test results:
  • Integration test implementation:

Documentation Links

  • Usage:
  • Contribution:
  • Licensing:
2

Thanks @arturo-seijas for the review request!

@dylanstathis can you please help with this review? You can go through and tick off the items on the checklist and post the result in this thread. This prior listing request could serve as an example of how to go about it. Please ping me or anyone from Charm-Tech for any questions.

3

I have only one issue:

The only tests I can find are in the charm/tests directory and there is only “test_build_and_deploy” and “test_actions”. This is definitely not enough test coverage. If there are other tests somewhere else, please let me know, otherwise more tests need to be added.

Everything else looks fine to me so once the above is addressed, we can do the demo and get the charm approved.

4

This charm is a bit particular since it’s a 12-factor charm:

  • Unit tests for the packed django application are present in httprequest-lego-provider/tests`. I think those provide 100% coverage of the API
  • When it comes to the charm, I don’t see a lot of possibilities to unit test it so I decided to integration test the exposed actions, that covers all the functionality exposed by the charm and all the charm code that expands the 12-factor behavior Can you narrow down which tests do you miss?
5

@arturo-seijas My bad I didn’t understand that it was a 12-factor charm. Looks good to me. We can schedule a meeting for a demo or you can send me a video of the charm working, then we will be done.

1 Like
6

@tony-meyer Approved.

1 Like
7

Thanks @dylanstathis !

@odysseus-k This one should be good for listing now, thanks!

8

Hi,

The charm has been successfully listed as requested.

Thanks,

Odysseus

1 Like