Thanks @sgeorget for the review request! I’m sure you figured this already, but note that it’s likely to be a bit of a delay before this one gets processed with the end of year coming up. I would guess that the review probably won’t start before January, sorry.
@reneradoi can you please help with this review? You can go through and
tick off the items on the checklist
and post the result in this thread. This prior listing request could serve as an example of how to go about it. Please ping
me or anyone else from Charm-Tech for any questions.
The review for the source code has been conducted. The overall quality of code, docs, tests and automation is pretty good, only some minor topics have been added as a comment here.
Before confirming the “publication readiness”, the requested change (replacing passlib module) should be implemented. Other than that, there are no concerns from my side.
Once the PR has been updated, I will add the review checklist here, too.