Review `datahub-k8s` charm for listing

[amber-charitos]

Requesting on behalf of Mert Alp Taytak (mertalp.taytak@canonical.com).

The Charmed DataHub K8s Operator delivers automated management of DataHub metadata platform on top of a Kubernetes cluster. DataHub is an open source data catalog software designed to streamline metadata management, data discovery, and data governance.

PR for code review: https://github.com/canonical/datahub-k8s-operator/pull/9

Metadata links charmhub.io: Charmhub | Deploy DataHub using Charmhub - The Open Operator Collection project repository: GitHub - canonical/datahub-k8s-operator

CI Links

• Code linting or-style checks: datahub-k8s-operator/tox.ini at main · canonical/datahub-k8s-operator · GitHub
• Release automation: datahub-k8s-operator/.github/workflows/publish_charm.yaml at main · canonical/datahub-k8s-operator · GitHub
• Unit test implementation: datahub-k8s-operator/.github/workflows/test.yaml at main · canonical/datahub-k8s-operator · GitHub
• Unit test results: Review Charm for Listing · canonical/datahub-k8s-operator@1f04c9b · GitHub
• Integration test implementation: datahub-k8s-operator/.github/workflows/integration_test.yaml at main · canonical/datahub-k8s-operator · GitHub
• Integration test results: Change publish workflow for compatibility with integration tests workflow · canonical/datahub-k8s-operator@7da15a8 · GitHub

Documentation Links

• Usage: Charmhub | Deploy Datahub Operator using Charmhub - The Open Operator Collection
• Contribution: datahub-k8s-operator/CONTRIBUTING.md at main · canonical/datahub-k8s-operator · GitHub
• Licensing: datahub-k8s-operator/LICENSE at main · canonical/datahub-k8s-operator · GitHub
• Publisher: Mert Alp Taytak (mertalp.taytak@canonical.com) Canonical Commercial Systems

[tony-meyer]

Many apologies for the very slow response here - I was trying to keep an eye out for requests during the sprints but missed this, and then I was off for a week after the sprint, so am only now catching up (and I only get an email if the post is in the review requests sub category - maybe I should change that to watch the larger requests category instead).

@neppel (@neppel1? It’s annoying that the directory doesn’t list Discourse user names…) can you please help with this review? You can go through and tick off the items on the checklist and post the result in this thread. This prior listing request could serve as an example of how to go about it. Please ping me or anyone else from the Charm-Tech team if you have any questions.

[tony-meyer]

@mertalpt this seems to have fallen through the gaps .

I’ll get someone to handle this next week as soon as we’re back from the sprint.

[mertalpt (Mert Alp Taytak)]

@tony-meyer Can we close this request for now? I will open a new one once the charm is more mature.

This charm had to do many uncommon things and I had to resort to workarounds. If there is spare time to do a preliminary review I would still appreciate it. I would need to open a new comparison PR though, so please let me know.

[tony-meyer]

@mertalpt

@tony-meyer Can we close this request for now? I will open a new one once the charm is more mature.

Sure. For what it’s worth, Charm-Tech is going to revamp the listing review process this cycle to try to solve the timing, inconsistency, lack of clarify issues, so things should go better next time.

@mertalpt

If there is spare time to do a preliminary review I would still appreciate it. I would need to open a new comparison PR though, so please let me know.

Sure. Just ping @canonical/charm-tech in the PR and we’ll see it.