JIMM K8s Charmhub review

[kian-parvin]

We would like the JIMM k8s charm belonging to the Yellow squad to be searchable/visible on Charmub.
Just a note that the “Yellow squad” was traditionally used for the commercial-systems team in Canonical. We also have a newer commercial-systems team where ownership can be transferred if desired.

A note:
The charm is a private repo to make integration tests easier since the JIMM repo is private. The intention is that the charm repo will be made public when the source repo is made public.

Can you please help us to have it reviewed?

Deploy JIMM-K8S using Charmhub - The Open Operator Collection

Charm Summary

(Taken from the charm readme)
JIMM is a extension of Juju, an open source orchestration engine, providing additional capabilities to your Juju environments. The JIMM K8s charm is the easiest and the recommended way to deploy JIMM. This charm installs and configures the JIMM server.

Review PR

• https://github.com/canonical/jimm-k8s-operator/pull/4

Metadata links

• charmhub.io:
  • https://charmhub.io/juju-jimm-k8s
• project repository:
  • https://github.com/canonical/jimm-k8s-operator/

CI Links

• Code linting or-style checks:
  • https://github.com/canonical/jimm-k8s-operator/blob/v3/.github/workflows/test.yaml#L11
• Release automation:
  • https://github.com/canonical/jimm-k8s-operator/blob/v3/.github/workflows/publish.yaml
  • https://github.com/canonical/jimm-k8s-operator/blob/v3/.github/workflows/promote.yaml
• Unit test implementation:
  • https://github.com/canonical/jimm-k8s-operator/blob/v3/.github/workflows/test.yaml#L24
• Unit test results:
  • https://github.com/canonical/jimm-k8s-operator/actions/runs/9000007780/job/24723356093
• Integration test implementation:
  • https://github.com/canonical/jimm-k8s-operator/tree/v3/tests/integration
• Integration test results:
  • https://github.com/canonical/jimm-k8s-operator/actions/runs/9000007780/job/24723439135

Documentation Links

• Usage:
  • https://charmhub.io/juju-jimm-k8s
  • https://canonical-jaas-documentation.readthedocs-hosted.com/en/latest/
• Contribution:
  • https://github.com/canonical/jimm-k8s-operator/blob/v3/CONTRIBUTING.md
• Licensing:
  • https://github.com/canonical/jimm-k8s-operator/blob/v3/LICENSE

[varshigupta]

Thanks for the review request @kian-parvin! @arturo-seijas can you please help with this review? You can go through and tick off the items on the checklist available hereand post the result in this thread. This prior listing request is an example of how to do it.

[arturo-seijas (Arturo Enrique Seijas Fernández)]

Hi @kian-parvin , the link https://github.com/canonical/jimm-k8s-operator/pull/4 retuns a 404 for me. Is it possible that this is a private repostiory?

[kian-parvin]

Hi @arturo-seijas, yes the charm is a private repository currently. I’ve quoted below the reason for that.

@kian-parvin

The charm is a private repo to make integration tests easier since the JIMM repo is private. The intention is that the charm repo will be made public when the source repo is made public.

The longer explanation is that our source code repo is also private and Github does not allow pull-requests from forks to access repo secrets, and we need a repo secret for running the charm integration tests. This limitation will be removed once the source repo becomes public.