Review `superset-k8s` charm for listing

charmhub requests review requests
1

The Charmed Superset K8s Operator delivers automated management of Superset data visulization software on top of a Kubernetes cluster. Apache Superset is an open-source data exploration and visualization platform.

PR for code review: https://github.com/canonical/superset-k8s-operator/pull/14

Metadata links

CI Links

Documentation Links

2

Hi @amber-charitos ,

Thank you for the review request! @ghibourg: can you please assist @amber-charitos with a review of the superset charm? Let me or anyone else in the @review-coordinators group know if we can be of any help.

Best, Simon

3

Hi @amber-charitos and @0x12b,

I did a review on the PR and approved it. I also left some nitpicks and improvement suggestions, but I don’t think anything should prevent publishing as-is.

Ghislain

4

Could you please tick off the checklist from Reviewing charms in this topic?

5

Here is the checklist:

Checked Review item Objective Review criteria
✓ Intended functionality Despite all the items for publication readiness, the charm must work. Charm does what it is meant to do - ideally done in a demo.
✓ Charmhub.io charm detail page A complete and consistent appearance of the charm is required for a quality impression of the charm collection. The overall appearance looks good, which means:
* The name complies with the naming guidelines.
* The publisher is identified.
* The links are provided.
* The documentation looks reasonable.
✓ Source repository Generally, the source code for charms must be accessible by the community for transparency and collaboration. It is not entirely mandatory to have the charm published as OSS for review, but the repository must be accessible from the persons working on the review request.
✓ Coding conventions The source code of the charm is accessible in the sense of approachability. Consistent source code style and formatting are also considered a sign of being committed to quality. The implemented checks for coding conventions are reasonable and implemented in the regular CI/CD implementation.
✓ Release automation implementation An implementation for automated releasing to charmhub.io improves the ability to provide updates covering vulnerabilities quickly. Release automation for unstable channels to enable testing when new versions of the charm code or the workload become available.
✓ Unit tests implementation In particular, for the charms review, assuring a reasonable test suite is essential to allow for automated releases in future. The unit tests show relevant coverage. It is a case-dependent review.At the time of review, the test runs successfully.
✓ Unit tests results Availability of test results is mandatory for a working collaborative project. URL to test results from CI/CD automation.
✓ Installation test implemented (could be part of the integration test) In particular, for the charm review, assuring a reasonable test suite is essential to allow for automated releases in future. With this test, for every build, it is ensured that the installation is successful. An implementation for checking the installation is present. The implementation should also check for successful installation as part of the automation, and the workload behaves as expected. At the time of review, the test runs successfully.
✓ Installation test results Availability of test results is mandatory for a working collaborative project. URL to test results from CI/CD automation.
✓ Integration tests implemented In particular for the review of charms, assuring a reasonable test suite is important to allow for automated releases in future. With this test, for every build, it is ensured that the integration with other charms is successful. An implementation for testing the required integrations (if applicable) is present. The implementation should also check for successful integration as part of he automation and the workload behaves as expected.
At the time of review, the test runs successfully.
✓ Integration test results Availability of test results is mandatory for a working collaborative project. URL to test results from CI/CD automation.
✓ Documentation for usage The documentation for using the charm should be separate from the documentation for developing or contributing to the charm. URL to this documentation is present.
✓ Documentation for contributing The documentation for contributing to the charm should be separate from the documentation for developing or using the charm. URL to this documentation is present.
✓ Licensing statement For the charm shared, OSS or not, the licensing terms of the charm are clarified (which also implies an identified authorship of the charm). URL to the ruling licensing statement is present.
1 Like
6

Thanks @ghibourg and @0x12b. I will address the suggestions :slight_smile:, in the meantime please let me know the next steps for having the charm listed. I would also like to change the ownership of the charm to Commercial Systems while remaining an editor, should this be a separate discourse request topic?

1 Like
7

I guess that is a now a standard charmhub request issue. @odysseus-k could we please ask you for setting this charm at superset-k8s-operator to listed? As seen in the thread above, it is ready for publication by our criteria.

8

Hi,

This is done.

Set superset-k8s as listed
{'ok': True}

Thanks,

Odysseus

2 Likes