Review `openstack-exporter ` charm for listing

charmhub requests review requests
1

The Charmed OpenStack Exporter Operator is a machine charm for openstack-exporter.

OpenStack Exporter is a Prometheus exporter for OpenStack, which uses the OpenStack REST APIs to produce metrics about the OpenStack cloud. This charm deploys OpenStack Exporter, configures it to connect to an OpenStack deployment using Keystone, and provides integration with Canonical Observability Stack (COS) (via grafana-agent). It also includes some Grafana dashboards that use provided metrics.

This can be useful to operators and admins looking for more insights into a Charmed OpenStack cloud.

PR for code review: Review Charm for Listing by jneo8 · Pull Request #100 · canonical/openstack-exporter-operator · GitHub

Metadata links

CI Links

Documentation Links

2

Thanks @jneo8 for the review request!

@jdkandersson can you please help with this review? You can go through and tick off the items on the checklist and post the result in this thread. This prior listing request could serve as an example of how to go about it. Please ping @review-coordinators for any questions.

1 Like
3

Started the review

1 Like
4

Review still in progress, just including the template below for now:

  • Code review ongoing
  • Test review ongoing
  • The rest looks fine
Review item Objective Review criteria Review comment
Intended functionality Despite all the items for publication readiness, the charm must work. Charm does what it is meant to do - ideally done in a demo.
Charmhub.io charm detail page A complete and consistent appearance of the charm is required for a quality impression of the charm collection. The overall appearance looks good, which means:
* The name complies with the naming guidelines.
* The publisher is identified.
* The links are provided.
* The documentation looks reasonable.		 :heavy_check_mark:
Source repository Generally, the source code for charms must be accessible by the community for transparency and collaboration. It is not entirely mandatory to have the charm published as OSS for review, but the repository must be accessible from the persons working on the review request. :heavy_check_mark:
Coding conventions The source code of the charm is accessible in the sense of approachability. Consistent source code style and formatting are also considered a sign of being committed to quality. The implemented checks for coding conventions are reasonable and implemented in the regular CI/CD implementation. :heavy_check_mark:
Release automation implementation An implementation for automated releasing to charmhub.io improves the ability to provide updates covering vulnerabilities quickly. Release automation for unstable channels to enable testing when new versions of the charm code or the workload become available. :heavy_check_mark:
Unit tests implementation In particular, for the charms review, assuring a reasonable test suite is essential to allow for automated releases in future. The unit tests show relevant coverage. It is a case-dependent review.At the time of review, the test runs successfully. :heavy_check_mark:
Unit tests results Availability of test results is mandatory for a working collaborative project. URL to test results from CI/CD automation. :heavy_check_mark:
Installation test implemented (could be part of the integration test) In particular, for the charm review, assuring a reasonable test suite is essential to allow for automated releases in future. With this test, for every build, it is ensured that the installation is successful. An implementation for checking the installation is present. The implementation should also check for successful installation as part of the automation, and the workload behaves as expected. At the time of review, the test runs successfully. :heavy_check_mark:
Installation test results Availability of test results is mandatory for a working collaborative project. URL to test results from CI/CD automation. :heavy_check_mark:
Integration tests implemented In particular for the review of charms, assuring a reasonable test suite is important to allow for automated releases in future. With this test, for every build, it is ensured that the integration with other charms is successful. An implementation for testing the required integrations (if applicable) is present. The implementation should also check for successful integration as part of he automation and the workload behaves as expected.
At the time of review, the test runs successfully.		 :heavy_check_mark:
Integration test results Availability of test results is mandatory for a working collaborative project. URL to test results from CI/CD automation. :heavy_check_mark:
Documentation for usage The documentation for using the charm should be separate from the documentation for developing or contributing to the charm. URL to this documentation is present. :heavy_check_mark:
Documentation for contributing The documentation for contributing to the charm should be separate from the documentation for developing or using the charm. URL to this documentation is present. :heavy_check_mark:
Licensing statement For the charm shared, OSS or not, the licensing terms of the charm are clarified (which also implies an identified authorship of the charm). URL to the ruling licensing statement is present. :heavy_check_mark:
1 Like
5

As of now the remaining items are:

  • Integration/ installation tests did not pass on the main branch for the latest commit
  • Need to have a demo of the charm working
1 Like
6

HI @jdkandersson

I have question about the demo part. Is that means I should find you for a demo?

7

@jneo8 yes please organise a meeting with me, my calendar is up to date :slight_smile:

2 Likes
8

Hi @jdkandersson

The newest integration is pass on Add limit:1 in the cos-agent relation (#122) · canonical/openstack-exporter-operator@783f90d · GitHub

For the demo, we need sometime to prepare the environment, I will schedule the meeting later after it is ready.

1 Like
9

Thank you, updated the review checklist. Only the demo to go!

2 Likes