Review `trino-k8s` charm for listing

Hi there, I’m requesting this charm for listing even though it is already listed as it did not go through this review process when it was listed (due to the process not being created then). Happy for you to unlist it while this review takes place.


Trino is a distributed SQL query engine designed to query large data sets distributed over one or more heterogeneous data sources.

This operator provides a Trino server, and consists of Python scripts which wraps versions distributed by the Trino software foundation.

PR for code review: https://github.com/canonical/trino-k8s-operator/pull/24/files

Metadata links

CI Links

Documentation Links

@weii-wang can you please assist Amber by going through and ticking off the items on the checklist available here and post the result in this thread? You can use this prior listing request as an example.

No problem, I will take a look.

@amber-charitos @varshigupta

I have finished the charm review, and I didn’t see any functionality problem within the charm. I think it’s good to go! Left some suggestions and nitpicks in the review.

Checked Review item Objective Review criteria
Intended functionality Despite all the items for publication readiness, the charm must work. Charm does what it is meant to do - ideally done in a demo.
Charmhub.io charm detail page A complete and consistent appearance of the charm is required for a quality impression of the charm collection. The overall appearance looks good, which means:
* The name complies with the naming guidelines.
* The publisher is identified.
* The links are provided.
* The documentation looks reasonable.
Source repository Generally, the source code for charms must be accessible by the community for transparency and collaboration. It is not entirely mandatory to have the charm published as OSS for review, but the repository must be accessible from the persons working on the review request.
Coding conventions The source code of the charm is accessible in the sense of approachability. Consistent source code style and formatting are also considered a sign of being committed to quality. The implemented checks for coding conventions are reasonable and implemented in the regular CI/CD implementation.
Release automation implementation An implementation for automated releasing to charmhub.io improves the ability to provide updates covering vulnerabilities quickly. Release automation for unstable channels to enable testing when new versions of the charm code or the workload become available.
Unit tests implementation In particular, for the charms review, assuring a reasonable test suite is essential to allow for automated releases in future. The unit tests show relevant coverage. It is a case-dependent review.At the time of review, the test runs successfully.
Unit tests results Availability of test results is mandatory for a working collaborative project. URL to test results from CI/CD automation.
Installation test implemented (could be part of the integration test) In particular, for the charm review, assuring a reasonable test suite is essential to allow for automated releases in future. With this test, for every build, it is ensured that the installation is successful. An implementation for checking the installation is present. The implementation should also check for successful installation as part of the automation, and the workload behaves as expected. At the time of review, the test runs successfully.
Installation test results Availability of test results is mandatory for a working collaborative project. URL to test results from CI/CD automation.
Integration tests implemented In particular for the review of charms, assuring a reasonable test suite is important to allow for automated releases in future. With this test, for every build, it is ensured that the integration with other charms is successful. An implementation for testing the required integrations (if applicable) is present. The implementation should also check for successful integration as part of he automation and the workload behaves as expected.
At the time of review, the test runs successfully.
Integration test results Availability of test results is mandatory for a working collaborative project. URL to test results from CI/CD automation.
Documentation for usage The documentation for using the charm should be separate from the documentation for developing or contributing to the charm. URL to this documentation is present.
Documentation for contributing The documentation for contributing to the charm should be separate from the documentation for developing or using the charm. URL to this documentation is present.
Licensing statement For the charm shared, OSS or not, the licensing terms of the charm are clarified (which also implies an identified authorship of the charm). URL to the ruling licensing statement is present.

Thank you @weii-wang I’ll address your suggestions with a new PR :slight_smile: Also interesting to learn about juju-http-proxy etc. which I was not aware of. Thank you for bringing this to my attention!

@odysseus-k The trino-k8s charm should be good to be listed. Can you please go ahead with the listing?

Hello,

the charm trino-k8s is marked as listed.

Best regards, Milos

1 Like