I’d like to propose our ceph-dashboard charm for listing. It’s been in use for a while as part of the OpenStack Charmers offering, and is being developed under the OpenStack umbrella.
I’ve filled out the form as per below, please let me know if there’s any questions.
Thank you for submitting a review request! @ca-scribner, can you please assist Peter with the charm review? Feel free to ping @review-coordinators if there are any questions.
This review did not go through a PR, but here is a preliminary review:
Intended functionality: TBC
I didn’t manage to deploy the bundle jammy-yoga.yaml to test it. Do you perhaps have a demo of it in action? or some script with all the pre-requisites prior to deploying the bundle?
The OpenStack dev model does not lend itself well to creating arbitrary branches. I’ve therefore created a branch from the Github mirror, hope this works too:
I presume you were referring to tests/bundles/jammy-yoga.yaml? Typically these would be deployed in CI in our test environment. Typically Ceph will be deployed to a MAAS substrate, but an OpenStack undercloud would also work (this is what we’re using in testing), but e.g. LXD provider will not.
Ref the licensing statement, the ask is to have a statement in the README, such as in https://github.com/canonical/pgbouncer-k8s-operator#license I admit it is not critical, because the license file is present and millions of projects implement the same practise. If you find the time add it to the next commit on the README.md, it would make a sound impression though.
A propos readme.md. Had a quick look on the contribution guidelines - I need to admit that also for me it is not obvious how to find documentation about how to contribute to the project. I see that deployment, architecture, concepts are all relevant for contributing to the charm development. However, a contribution guideline in the sense of https://gist.github.com/briandk/3d2e8b3ec8daf5a27a62
I also did not find. If it exists, how about adding such link to the README - along with a licensing statement?