Review Charm for Listing: Ceph Dashboard

charmhub requests review requests
#1

Hi,

I’d like to propose our ceph-dashboard charm for listing. It’s been in use for a while as part of the OpenStack Charmers offering, and is being developed under the OpenStack umbrella.

I’ve filled out the form as per below, please let me know if there’s any questions.

Metadata links

  • project repository:

https://opendev.org/openstack/charm-ceph-dashboard Mirrored at https://github.com/openstack/charm-ceph-dashboard

CI Links

  • Code linting or-style checks:

We’re using flake8, tox.ini:

https://opendev.org/openstack/charm-ceph-dashboard/src/branch/master/tox.ini

  • Release automation:

Build automation info is kept in https://github.com/openstack-charmers/charmed-openstack-info

  • Unit test implementation:

https://opendev.org/openstack/charm-ceph-dashboard/src/branch/master/unit_tests

  • Unit test results:

https://zuul.opendev.org/t/openstack/buildset/d74010eb63ea49e98e19ef4fd81cd43f

  • Integration test implementation:

https://opendev.org/openstack/charm-ceph-dashboard/src/branch/master/tests https://github.com/openstack-charmers/zaza-openstack-tests

  • Integration test results:

Documentation Links

  • Usage:

Usage is documented here: Ceph Dashboard install | Ubuntu

  • Contribution:

Developer info is kept as part of the OpenStack Charm Guide: https://docs.openstack.org/charm-guide/latest/

  • Licensing:

https://opendev.org/openstack/charm-ceph-dashboard/src/branch/master/LICENSE

  • Publisher:

We can be reached at openstack-discuss@lists.openstack.org

#2

Hi @chrome0 ,

Thank you for submitting a review request! @ca-scribner, can you please assist Peter with the charm review? Feel free to ping @review-coordinators if there are any questions.

Best, Simon

#3

@0x12b I’m probably not the best to help atm. I’m out of office till late October. Is there someone else you have in mind?

#4

Hah! Yeah, that makes no sense then. Thanks for letting me know! How about @medib instead?

#5

There is an initial issue with the charms from the open stack team.

The publisher is not clear, as who is the group which provides the charm? It is unclear if it is from canonical or from the openinfra foundation.

@billy-olsen it might be a good opportunity to cover this question for this review.

#6

and … please allow me to repeat my remark about the appearance on the detail page on charmhub ref to the two “lonely” lines:

Enable dashboard for Ceph
Enable the ceph dashboard on the ceph mon units

How about adding an information about getting started at least there?

#7

Wrt to docs we’ve just merged the necessary metadata.yaml update, should be reflected in charmhub shortly

#8

@medib Please proceed by ticking off the checklist from Reviewing charms in this topic. :slight_smile:

#9

Hi @chrome0,

This review did not go through a PR, but here is a preliminary review:

  1. Intended functionality: TBC
    • I didn’t manage to deploy the bundle jammy-yoga.yaml to test it. Do you perhaps have a demo of it in action? or some script with all the pre-requisites prior to deploying the bundle?
  2. Charmhub.io charm detail page: OK
    • Could you add a link to the deployment guide of a “ceph cluster” (which is listed as a pre-requisite to using this charm)?
  3. Source repository: OK
  4. Coding conventions: OK
  5. Release automation implementation: TBC
    • Could you share the pipeline where this happens?
  6. Unit tests implementation: OK
  7. Unit tests results: OK
  8. Installation test implemented (could be part of the integration test): OK
  9. Installation test results: OK
  10. Integration tests implemented: OK
  11. Integration test results: OK
  12. Documentation for usage: OK
    • Could you add a link to the deployment guide of a “ceph cluster” (which is listed as a pre-requisite to using this charm)?
  13. Documentation for contributing: MISSING
  14. Licensing statement: MISSING in README

Could you:

  • make a PR?
  • take a look at: 1, 2, 5, 12, 13, 14?
  • share with me where are the CI definition files invoked from?
  • fix: [testenv:func-dev]

Thank you

5 Likes